Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 76.30% 76.35% +0.05%
==========================================
Files 53 53
Lines 9363 9388 +25
==========================================
+ Hits 7144 7168 +24
- Misses 2219 2220 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
This was referenced Jan 22, 2025
This was referenced Jan 23, 2025
This was referenced Feb 3, 2026
This was referenced Feb 11, 2026
This was referenced Mar 2, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
* origin/pr/426: update run_tests packages fix utest when running without sudo add tests Dockerfile Pull request description: Note: requires QubesOS#424 (could do without, but might as well - this PR is not urgent) Maybe closes QubesOS/qubes-issues#10700 ?
* origin/pr/438: handle case where arg is None add type hints for app.py Pull request description: Follows QubesOS#437 * `_vm_list` is no a list - it's a dict. I renamed it accordingly. * I added a new `_vm_dict_initialized` variable that explicitly tracks the initialisation rather than relying on `is None`. (which avoids putting `assert is not None` everywhere) * (not done in this PR) I believe we should add a comment / docstring to state clearly what's supposed to be in both `_vm_list` and `_vm_objects`. Would be happy to add it to the PR if I get some suggestions. ```python3 def list_deviceclass(self) -> list[str]: ``` I would like to make `deviceclass` a `Literal` list of allowed strings, but I'm not sure what the exhaustive list of allowed classes are ? * What guarantees below that `volume.name` is not `None` ? ```python3 default_pool = getattr( self.app, "default_pool_" + volume.name, volume.pool ) ``` * Same for `dst_volume.name` a bit after: ```python3 src_volume = src_vm.volumes[dst_volume.name] ``` * in `qubesd_call` we have ```python3 def qubesd_call( self, dest, method, arg=None, payload=None, payload_stream=None ): if payload_stream: method_path = os.path.join( qubesadmin.config.QREXEC_SERVICES_DIR, method ) if not os.path.exists(method_path): raise qubesadmin.exc.QubesDaemonCommunicationError( "{} not found".format(method_path) ) command = [ "env", "QREXEC_REMOTE_DOMAIN=dom0", "QREXEC_REQUESTED_TARGET=" + dest, method_path, arg, ] self._call_with_stream( command, payload, payload_stream ) ``` * This will fail if `dest=None` but this is not mentioned in the docstring * This should also fail if `arg` is `None` since _call_with_stream excepts a `list[str]`, not `list[str|None]`. Is that OK ?
This was referenced Mar 15, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QubesOS/qubes-issues#9231