Skip to content

Add Arch packaging#332

Open
marmarek wants to merge 8 commits intoQubesOS:mainfrom
marmarek:archlinux
Open

Add Arch packaging#332
marmarek wants to merge 8 commits intoQubesOS:mainfrom
marmarek:archlinux

Conversation

@marmarek
Copy link
Member

@marmarek marmarek commented Jan 20, 2025

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

❌ Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.35%. Comparing base (1efaa45) to head (71b1e21).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
qubesadmin/app.py 98.52% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   76.30%   76.35%   +0.05%     
==========================================
  Files          53       53              
  Lines        9363     9388      +25     
==========================================
+ Hits         7144     7168      +24     
- Misses       2219     2220       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented Jan 21, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026031512-4.3&flavor=pull-requests

Test run included the following:

Installing updates failed, skipping the report!

anon and others added 7 commits March 13, 2026 13:39
* origin/pr/426:
  update run_tests packages
  fix utest when running without sudo
  add tests Dockerfile

Pull request description:

Note: requires QubesOS#424 (could do without, but might as well - this PR is not urgent)

Maybe closes QubesOS/qubes-issues#10700 ?
* origin/pr/438:
  handle case where arg is None
  add type hints for app.py

Pull request description:

Follows QubesOS#437

* `_vm_list` is no a list - it's a dict. I renamed it accordingly.
* I added a new `_vm_dict_initialized` variable that explicitly tracks the initialisation rather than relying on `is None`. (which avoids putting `assert is not None` everywhere)
* (not done in this PR) I believe we should add a comment / docstring to state clearly what's supposed to be in both `_vm_list` and `_vm_objects`. Would be happy to add it to the PR if I get some suggestions.

```python3
def list_deviceclass(self) -> list[str]:
```

I would like to make `deviceclass` a `Literal` list of allowed strings, but I'm not sure what the exhaustive list of allowed classes are ?

* What guarantees below that `volume.name` is not `None` ?

```python3
default_pool = getattr(
                    self.app, "default_pool_" + volume.name, volume.pool
                )
```

* Same for `dst_volume.name` a bit after:
```python3
src_volume = src_vm.volumes[dst_volume.name]
```

* in `qubesd_call` we have
```python3
    def qubesd_call(
        self, dest, method, arg=None, payload=None, payload_stream=None
    ):
        if payload_stream:
            method_path = os.path.join(
                qubesadmin.config.QREXEC_SERVICES_DIR, method
            )
            if not os.path.exists(method_path):
                raise qubesadmin.exc.QubesDaemonCommunicationError(
                    "{} not found".format(method_path)
                )
            command = [
                "env",
                "QREXEC_REMOTE_DOMAIN=dom0",
                "QREXEC_REQUESTED_TARGET=" + dest,
                method_path,
                arg,
            ]
          self._call_with_stream(
                command, payload, payload_stream
            )
```

  * This will fail if `dest=None` but this is not mentioned in the docstring
  * This should also fail if `arg` is `None` since _call_with_stream excepts a `list[str]`, not `list[str|None]`. Is that OK ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants